Repository navigation
libdatadog update to 21962c07 - #4291
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 4 Pipeline jobs failed
ℹ️ InfoNo other issues found (see more)🧪 All tests passed 🎯 Code Coverage (details) Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 8414c27 | Docs | View more details | Give us feedback! |
25ec9c6 to
4b1f716
Compare
a9d6e21 to
23d4e93
Compare
278672b to
21f077a
Compare
3832631 to
804fd86
Compare
There was a problem hiding this comment.
The updated webpki requirements conflict with the committed Cargo.lock. On a dependency-cache miss, the sanitizer workflow’s locked fetch will fail before the ASAN/UBSAN matrices can run.
🤖 Bits Code Review · Commit f833984
Benchmarks [ tracer ]Benchmark execution time: 2026-10-23 17:09:28 Comparing candidate commit 8414c27 in PR branch Found 0 performance improvements and 5 performance regressions! Performance is the same for 189 metrics, 0 unstable metrics.
|
f833984 to
024f856
Compare
There was a problem hiding this comment.
More details
The workspace dependency additions and lockfile are consistent, and the removed Windows callback declarations have no callers in the accessible code. The updated libdatadog sources and build behavior remain incompletely verified.
🤖 Bits Code Review · Commit 024f856
024f856 to
4f05125
Compare
Automated update by CI pipeline https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-php/-/pipelines/146949581 Full CI result: ❌ 1 job(s) failed
d25a418 to
0a01a83
Compare
Automated update by CI pipeline https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-php/-/pipelines/146961638 Full CI result: ❌ 244 job(s) failed
fce6c28 to
8414c27
Compare
Summary
Automated update of the libdatadog submodule to the latest HEAD.
$LIBDATADOG_PINNED_SHA21962c07061b324669aaf9e58cc7cefce7227b7cFull CI result: ❌ 244 job(s) failed
CI pipeline: https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-php/-/pipelines/146961638
libdatadog Integration Report
libdatadog SHA: 21962c07061b324669aaf9e58cc7cefce7227b7c
Analysis date: 2026-10-23
Overall status
The changes are build-manifest changes, not Rust source changes. They could not
be checked locally because no Rust toolchain is available. CI must confirm them.
Build & test summary
244 jobs failed across the shared, appsec, profiler, package and tracer
sub-pipelines. Every saved trace (45 + 48 of 93 files) shows one of two Cargo
errors. Both happen while Cargo reads the manifests or resolves dependencies,
before any Rust code is compiled:
Workspace inheritance failure (48 traces: appsec integration tests,
helper-rust, sidecar and portable builds):
libdatadog crates are built as members of our workspace, so they inherit
workspace = truedependencies from our rootCargo.toml. That file mustmirror libdatadog's
[workspace.dependencies]. The new libdatadog addedthese entries:
webpki-rootsandwebpki-root-certs: libdd-common, from ci(profiling): cleanup correctness tests #2702 "bump toexclude compromised CAs"
httpdate: libdd-ffe CDN fetching, from Bump version to 1.0.0 #2675It also raised the
rustls-webpkirequirement to0.103.16(Use valgrind suppressions instead of disabling valgrind #2708).rustls-webpkiresolution conflict (45 traces: appsec code coverage,test appsec extension, profiling tests):
libdd-common now requires
rustls-webpki ^0.103.16. OurCargo.lockstillpinned
0.103.13, and these jobs resolve with only the locked versionavailable, so resolution fails.
The remaining job families have no saved traces: Extension Tea Tests, Zend
Abstract Interface Tests, ZAI Shared Tests, PHP language tests,
prof-correctness, Clippy, Cargo test and pecl tests. They all build the same
Cargo workspace first:
zend_abstract_interface/components_rs.cmakemake installCargo.toml/Cargo.lockSo they fail for the same reason.
Rust API review of the update
The submodule moved from
634af2c84to21962c070(25 commits). I checkedeach breaking (
!) commit against our code:fix(ipc)!: require ShmSafeShmLimiter<Inner>/ShmLimiterMemory<Inner>now needInner: ShmSafeInner = ()(components-rs/sidecar.rs). libdatadog already implementsShmSafefor(), so nothing to change.move AttributeValue into libdd-trace-modellibdd-trace-modelAttributeValue). Added aCargo.lockentry.wire v1 payload to trace exporterTraceFilterer::filter_traces_v1now takesPooledTraceChunksTraceFilterer::new(components-rs/trace_filter.rs). No impact.v1-native span obfuscationcrashtracker: Windows module filterextern "system";collector_windowsremoved from the ffi crate's Windows default featureslibdd-crashtracker-ffiwithdefault-features = false, features = ["collector"]and don't useddog_crasht_init_windows. No impact.Non-trivial changes made
Cargo.toml([workspace.dependencies]): re-synced withlibdatadog/Cargo.tomlas the file's own comment asks:httpdate = "1.0"webpki-roots = "1.0.10"webpki-root-certs = "1.0.10"rustls-webpkifrom">=0.103.13"to"0.103.16"The two
[workspace.dependencies]lists are now identical (checked withdiff).Cargo.lock: brought in line with the new requirements. All versionsand checksums are copied from
libdatadog/Cargo.lock:rustls-webpki0.103.13 → 0.103.16webpki-roots1.0.6 → 1.0.10webpki-root-certs1.0.6 → 1.0.10libdd-trace-model 0.1.0path package, now referenced fromlibdd-tinybytes,libdd-trace-obfuscationandlibdd-trace-utilslibdd-commonnow listswebpki-rootsandwebpki-root-certs(optionaldeps of the
use_webpki_rootsfeature)libdd-ffenow lists its new optional CDN dependencies:base64 0.22.1,fastrand,flate2,futures-util,http-body-util,httpdate,hyper,percent-encoding,tokio-utilandurlEach of these crates already had exactly one compatible version in the lock.
If Cargo still wants to adjust anything it can do so automatically, because
our builds do not pass
--locked. Rerunningcargo update -wlocally isstill a good idea, to normalise the lock file.
No Rust source files needed changes.
Identified libdatadog issues
None identified.
One design friction point, not a bug: every new
[workspace.dependencies]entry in libdatadog breaks dd-trace-php until our mirror in the root
Cargo.tomlis updated by hand. Automating that sync, or adding a CI check forit, would avoid this kind of failure.
Flaky / ignored failures
[tracer-trigger] macos test_c: failed withjob_execution_timeoutrather than a script failure, and no trace was saved. It most likely depends
on the same Cargo build and will be fixed with it. If it still times out once
the build works, treat it as a runner or infrastructure timeout.
.gitlab/flaky-jobs.txtand areexcluded from the merge gate:
Extension Tea Tests:*,Zend Abstract Interface Tests:*,test appsec extension:*andPHP language tests:*.In this pipeline they failed for the same build reason, not because they are
flaky.
/cc @bwoebi